[Mlir-commits] [mlir] [mlir][vector] Migrate drop-lead-unit-dim to shape_cast (PR #196206)

Erick Ochoa Lopez llvmlistbot at llvm.org
Thu May 7 06:30:24 PDT 2026


================
@@ -461,12 +519,22 @@ mlir::vector::castAwayContractionLeadingOneDim(vector::ContractionOp contractOp,
       rewriter.getArrayAttr(newIteratorTypes), contractOp.getKind());
 
   if (maskingOp) {
-    auto newMask = vector::ExtractOp::create(rewriter, loc, maskingOp.getMask(),
-                                             splatZero(dropDim));
+    auto oldMaskType = cast<VectorType>(maskingOp.getMask().getType());
+    if (oldMaskType.getRank() <= 1 ||
+        !isNonScalableUnitDim(oldMaskType, dimToDrop))
+      return failure();
----------------
amd-eochoalo wrote:

Same here.

https://github.com/llvm/llvm-project/pull/196206


More information about the Mlir-commits mailing list