[Mlir-commits] [mlir] [MLIR][WasmSSA] Instruction parser refactoring of WasmSSA importer (PR #195500)

[Luc Forget]

lforg37 wrote:

I'm not sure I get what you mean.
This is just parsing logic, and this is just refactoring so we don't need any new tests.

The goal of this PR is to be able to reuse the same mechanism of registering parser by declaring opcode overload for a specific parsing function.

If we want to add e.g. the missing non traping conversion de would have one new op per new conversion and the parser will create these ops by having two layers of binary decoder -> first byte will be used to select the sub-parser which will itself use the second byte to choose which exact op to create.

Let me know if I misunderstood your remark.

-------- Original Message --------
On Thursday, 05/07/26 at 22:06 Max Graey ***@***.***> wrote:

> MaxGraey left a comment [(llvm/llvm-project#195500)](https://github.com/llvm/llvm-project/pull/195500#issuecomment-4397356735)
>
> LGTM, but as far as I understand, this is only part of full prefix op code feature. We still need a printer and tests & examples right?
>
> —
> Reply to this email directly, [view it on GitHub](https://github.com/llvm/llvm-project/pull/195500#issuecomment-4397356735), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACW6NLG3O7IZWINIUP5MGE34ZSC5HAVCNFSM6AAAAACYOYYCMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGOJXGM2TMNZTGU).
> You are receiving this because you authored the thread.Message ID: ***@***.***>

https://github.com/llvm/llvm-project/pull/195500