[Mlir-commits] [llvm] [mlir] [Support] Faster line and column lookup in SourceMgr (PR #195881)

[llvmlistbot at llvm.org]

Albert =?utf-8?q?Havliček?= <havlialb at fit.cvut.cz>,
Albert =?utf-8?q?Havliček?= <havlialb at fit.cvut.cz>,
Albert =?utf-8?q?Havliček?= <havlialb at fit.cvut.cz>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/195881 at github.com>


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 130618 tests passed
* 2806 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Tools/PDLL/CodeGen/CMakeFiles/obj.MLIRPDLLCodeGen.dir/MLIRGen.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Tools/PDLL/CodeGen/CMakeFiles/obj.MLIRPDLLCodeGen.dir/MLIRGen.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\Tools\PDLL\CodeGen -IC:\_work\llvm-project\llvm-project\mlir\lib\Tools\PDLL\CodeGen -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\Tools\PDLL\CodeGen\CMakeFiles\obj.MLIRPDLLCodeGen.dir\MLIRGen.cpp.obj /Fdtools\mlir\lib\Tools\PDLL\CodeGen\CMakeFiles\obj.MLIRPDLLCodeGen.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Tools\PDLL\CodeGen\MLIRGen.cpp
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\Tools\PDLL\CodeGen\MLIRGen.cpp:10:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/AsmParser/AsmParser.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/AsmState.h:18:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/OperationSupport.h:19:
C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/BuiltinAttributes.h(346,14): warning: 'complex' is deprecated: warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. [-Wdeprecated-declarations]
346 |       return {APFloat(*smt, value.real()), APFloat(*smt, value.imag())};
|              ^
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\complex(1333,5): note: 'complex' has been explicitly marked deprecated here
1333 |     _DEPRECATE_NONFLOATING_COMPLEX
|     ^
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\yvals_core.h(1413,7): note: expanded from macro '_DEPRECATE_NONFLOATING_COMPLEX'
1413 |     [[deprecated("warning STL4037: "                                                   \
|       ^
C:\_work\llvm-project\llvm-project\mlir\lib\Tools\PDLL\CodeGen\MLIRGen.cpp(153,32): error: no member named 'getLineNumber' in 'llvm::SourceMgr::SrcBuffer'
153 |   unsigned lineNo = bufferInfo.getLineNumber(loc.getPointer());
|                     ~~~~~~~~~~ ^
1 warning and 1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/195881