[Mlir-commits] [mlir] [mlir][core] in -mlir-print-ir-*, dump the pass options as well (PR #195198)

[Jeremy Kun]

================
@@ -315,8 +317,19 @@ struct FileTreeIRPrinterConfig : public PassManager::IRPrinterConfig {
                             PrintCallbackFn printCallback) final {
     if (!shouldPrintBeforePass || !shouldPrintBeforePass(pass, operation))
       return;
-    std::unique_ptr<llvm::ToolOutputFile> file = createTreePrinterOutputPath(
-        operation, pass->getArgument(), treeDir, counters);
+
+    SmallVector<std::pair<std::string, std::string>> opAndSymbolNames;
+    std::string fileName;
+    {
+      std::lock_guard<std::mutex> lock(mutex);
----------------
j2kun wrote:

The failing test was mlir/test/Pass/ir-printing-file-tree.mlir, which was before [a5efcee](https://github.com/llvm/llvm-project/pull/195198/commits/a5efceebb4b5832a1cb7bccc60676556699c91f2). The failure was a timeout, it appeared to be a deadlock, so I did not see a backtrace. @joker-eph I would appreciate if you could try to reproduce it on an AArch64 machine.

https://github.com/llvm/llvm-project/pull/195198