[Mlir-commits] [mlir] [mlir][SYCL] Fail init errors cleanly instead of `abort`ing (PR #192979)

Md Abdullah Shahneous Bari llvmlistbot at llvm.org
Tue May 5 09:08:15 PDT 2026


https://github.com/mshahneo approved this pull request.

Overall LGTM. Some minor comments. Sorry for the delay, spilled through my radar. Thanks a lot for doing this.

Nit. 
- Although it's not part of the changes, but since you are updating the error messaging mechanisms in this file, maybe consider switching L0_SAFE_CALL's fprintf(stdout, ...) to stderr in the same patch for consistency, even if abort() stays?

- Maybe add #include <cstdlib> for std::exit / EXIT_FAILURE rather than relying on transitive include from SYCL headers.

https://github.com/llvm/llvm-project/pull/192979


More information about the Mlir-commits mailing list