[Mlir-commits] [flang] [mlir] [MLIR] Refactor DCE helper to expose worklist entry-point, and use this helper in CSE (PR #195636)

[Mehdi Amini]

joker-eph wrote:

> I think we are heading to a good refactor direction here.

I've been hesitant about this though: is the complexity really worth it here?

Since this is about ops that are trivially dead in the original program, do we really need to tangle this complex bookkeeping to be able to perform a single IR traversal or should we just have a separate IR traversal delegated to eliminateTriviallyDeadOps? 
The whole logic propagating the trivially dead ops in the parent worklist is not straightforward, and none of this enables any use-case on top of running `trivial-dce` in the first place.

https://github.com/llvm/llvm-project/pull/195636