[Mlir-commits] [clang] [mlir] [CIR] Add CIRABIRewriteContext for ABI function/call rewriting (PR #192119)

[Andy Kaylor]

https://github.com/andykaylor commented:

This is quite a lot to try to review. Could you break it down into smaller pieces? For example, maybe just implement the things that pass through directly and the tests for that, then implement extend, then coerce...?

I also wondered whether it would be possible to implement some kind of dummy architecture for testing that didn't use the LLVM ABI library so that the tests could be written as CIR-to-CIR transformations. I find the unit tests very difficult to understand.

https://github.com/llvm/llvm-project/pull/192119