[Mlir-commits] [clang] [llvm] [mlir] [LLVM][Constants] Store "splat (float 0.0)" as ConstantFP rather than ConstantAggregateZero. (PR #195284)

[Paul Walker]

paulwalker-arm wrote:

This was always part of the migration plan but I've escalated it due to the bug report.  The core change caused a lot of output churn, which is why I've modified AsmWriter.  I've split the PR into two commits so before and after is visible.  If printing `splat(float 0.0)` is preferable over `zeroinitializer` then I can either drop the top commit or land the PR as is and follow up with an NFC patch to revert the AsmWriter change in isolation.

The AsmWriter change does mean we're effectively maintaining the original ConstantAggregateZero form when transitioning through textual IR but I don't think that problematic.  In either case I'm assuming that I should follow up with a change to `Constant::getNullValue()` to emit a ConstantFP rather than ConstantAggregateZero?

https://github.com/llvm/llvm-project/pull/195284