[Mlir-commits] [clang] [flang] [lldb] [llvm] [mlir] [NFC] Silence -Wbool-integral-comparison warnings across LLVM (PR #195246)

[Eugene Epshteyn]

================
@@ -37,7 +37,7 @@ inline uint24_t getSwappedBytes(uint24_t C) {
 
 class DataExtractor {
   StringRef Data;
-  uint8_t IsLittleEndian;
+  bool IsLittleEndian;
----------------
eugeneepshteyn wrote:

I could be wrong, but I believe `bool` could be larger than 1 byte (although it's probably not larger in practice). If the intention of the original code that the size should be exactly 1 byte, there could be surprises with switching the type to `bool`. In any case, I suggest that the author gets to the bottom of this (perhaps via `git blame`).

https://github.com/llvm/llvm-project/pull/195246