[Mlir-commits] [mlir] [MLIR][MemRef] Fix DimOfReifyRankedShapedTypeOpInterface IR-change on failure (PR #188973)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar approved this pull request.

I understand that this is the expectation, but this is really a short term fix. The dim resolution as a pattern needs to go away, and instead it should probably be revisited, with a different approach that can explicitly track all operations created and erase them on failure instead of having to walk the program back.
This change is fine, but this is really more evidence that we need to change this pass to not use the pattern rewriter infra directly.

https://github.com/llvm/llvm-project/pull/188973