[Mlir-commits] [mlir] [mlir][GPU] Refactor GPUOps lowering (PR #188905)

[Hocky Yudhiono]

================
@@ -74,6 +75,69 @@ LLVM::GlobalOp mlir::getOrCreateStringConstant(OpBuilder &b, Location loc,
                                 name, attr, alignment, addrSpace);
 }
 
+FailureOr<LowerLLVMFuncAttrs> GPUFuncOpLowering::buildLoweredGPULLVMFuncAttrs(
+    gpu::GPUFuncOp gpuFuncOp, Type llvmFuncType, OpBuilder &rewriter) const {
+  FailureOr<LowerLLVMFuncAttrs> loweredAttrs =
+      lowerDiscardableAttrsForLLVMFunc(gpuFuncOp);
+  if (failed(loweredAttrs))
+    return failure();
+
+  // TODO: How do we refactor this to be deny list?
+  NamedAttrList &discardable = loweredAttrs->discardableAttrs;
----------------
hockyy wrote:

```
[gpu-lowering GPUOpsLowering.cpp:94 1] arg_attrs
[gpu-lowering GPUOpsLowering.cpp:94 1] function_type
[gpu-lowering GPUOpsLowering.cpp:94 1] known_block_size
[gpu-lowering GPUOpsLowering.cpp:94 1] known_cluster_size
[gpu-lowering GPUOpsLowering.cpp:94 1] known_grid_size
[gpu-lowering GPUOpsLowering.cpp:94 1] private_attrib_attrs
[gpu-lowering GPUOpsLowering.cpp:94 1] res_attrs
[gpu-lowering GPUOpsLowering.cpp:94 1] workgroup_attrib_attrs
```

These are the inherent attribute names

https://github.com/llvm/llvm-project/pull/188905