[Mlir-commits] [mlir] [mlir][vector] Remove unit-stride check in Gather1DToConditionalLoads (PR #189178)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3588 tests passed
* 415 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Dialect/Vector/vector-gather-lowering.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir --test-vector-gather-lowering | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir' --test-vector-gather-lowering
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir:172:11: error: CHECK: expected string not found in input
# | // CHECK: %[[CONST:.*]] = arith.constant 0 : index
# |           ^
# | <stdin>:212:67: note: scanning from here
# |  func.func @gather_memref_non_unit_stride_read_more_than_1_element(%arg0: memref<4xf32, strided<[2]>>, %arg1: vector<2xindex>, %arg2: vector<2xi1>, %arg3: vector<2xf32>) -> vector<2xf32> {
# |                                                                   ^
# | <stdin>:214:5: note: possible intended match here
# |  %1 = vector.extract %arg1[0] : index from vector<2xindex>
# |     ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Vector\vector-gather-lowering.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |              .
# |              .
# |              .
# |            207:  } else { 
# |            208:  scf.yield %arg3 : vector<1xf32> 
# |            209:  } 
# |            210:  return %2 : vector<1xf32> 
# |            211:  } 
# |            212:  func.func @gather_memref_non_unit_stride_read_more_than_1_element(%arg0: memref<4xf32, strided<[2]>>, %arg1: vector<2xindex>, %arg2: vector<2xi1>, %arg3: vector<2xf32>) -> vector<2xf32> { 
# | check:172'0                                                                       X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# |            213:  %0 = vector.extract %arg2[0] : i1 from vector<2xi1> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            214:  %1 = vector.extract %arg1[0] : index from vector<2xindex> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:172'1         ?                                                       possible intended match
# |            215:  %2 = scf.if %0 -> (vector<2xf32>) { 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            216:  %6 = vector.load %arg0[%1] : memref<4xf32, strided<[2]>>, vector<1xf32> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            217:  %7 = vector.extract %6[0] : f32 from vector<1xf32> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            218:  %8 = vector.insert %7, %arg3 [0] : f32 into vector<2xf32> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |            219:  scf.yield %8 : vector<2xf32> 
# | check:172'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |              .
# |              .
# |              .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/189178