[Mlir-commits] [mlir] [mlir][vscode plugin] Add feature to detect and run LIT tests commands encoded in '.mlir' test files (PR #186840)

[Christopher Bate]

================

----------------
christopherbate wrote:

The code is actually treating this as a path to a directory containing the executable, not the "path to the LIT executable". I think we should doing as described here -- this string could just be "llvm-lit" (command "llvm-lit" is on the Path) or a absolute or relative path to "llvm-lit". The executable could also be named anything -- "llvm-lit" or "lit" or "lit-shim.sh" -- the plugin shouldn't bake in an opinion on that.

With this in change, I think the special logic for handling virtual environments can be removed. The user can just create an executable script which invokes the correct Python interpreter if it needs to be different from the one available from the Path. Then they simply pass the path to that script to this setting. 

https://github.com/llvm/llvm-project/pull/186840