[Mlir-commits] [mlir] b3e2636 - [MLIR][SparseTensor] Fix direct op erasure bypassing rewriter in FoldConvertIntoProducer (#188960)

[llvmlistbot at llvm.org]

Author: Mehdi Amini
Date: 2026-03-27T10:59:03Z
New Revision: b3e26364109cd6654a801e303f0cb78dc304f145

URL: https://github.com/llvm/llvm-project/commit/b3e26364109cd6654a801e303f0cb78dc304f145
DIFF: https://github.com/llvm/llvm-project/commit/b3e26364109cd6654a801e303f0cb78dc304f145.diff

LOG: [MLIR][SparseTensor] Fix direct op erasure bypassing rewriter in FoldConvertIntoProducer (#188960)

FoldConvertIntoProducer called op->erase() directly instead of going
through the rewriter, which triggers an "unsupported erasure" error
under MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS.

Assisted-by: Claude Code

Fix a failure present with MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.

Co-authored-by: Claude Sonnet 4.6 <noreply at anthropic.com>

Added: 
    

Modified: 
    mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
index 89ed468d2e1b9..73777bc10bd39 100644
--- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
+++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
@@ -309,7 +309,7 @@ struct FoldConvertIntoProducer : public OpRewritePattern<ConvertOp> {
     });
 
     rewriter.replaceAllOpUsesWith(op, producer);
-    op->erase();
+    rewriter.eraseOp(op);
 
     return success();
   }