[Mlir-commits] [mlir] [mlir][GPU] Refactor GPUOps lowering (PR #188905)

[Mehdi Amini]

================
@@ -74,6 +75,69 @@ LLVM::GlobalOp mlir::getOrCreateStringConstant(OpBuilder &b, Location loc,
                                 name, attr, alignment, addrSpace);
 }
 
+FailureOr<LowerLLVMFuncAttrs> GPUFuncOpLowering::buildLoweredGPULLVMFuncAttrs(
+    gpu::GPUFuncOp gpuFuncOp, Type llvmFuncType, OpBuilder &rewriter) const {
+  FailureOr<LowerLLVMFuncAttrs> loweredAttrs =
+      lowerDiscardableAttrsForLLVMFunc(gpuFuncOp);
+  if (failed(loweredAttrs))
+    return failure();
+
+  // TODO: How do we refactor this to be deny list?
+  NamedAttrList &discardable = loweredAttrs->discardableAttrs;
----------------
joker-eph wrote:

I'm confused why there are present in there in the first place? Aren't these inherent attributes for gpuFuncOp? I would think they wouldn't be present in the discardableAttrs...

https://github.com/llvm/llvm-project/pull/188905