[Mlir-commits] [mlir] [memref] Simplify loads from reinterpret_cast of 1D contiguous memrefs (PR #188459)

[Andrzej Warzyński]

================
@@ -220,3 +221,309 @@ func.func private @negative_plain_copy(%src : memref<1x1xf32>,
   : memref<1x1xf32> to memref<1x1xf32>
   return
 }
+
+
+// -----
+
+//===----------------------------------------------------------------------===//
+// Positive tests
+//===----------------------------------------------------------------------===//
+
+// CHECK-LABEL: func.func private @reshape_expand_scalar(
+// CHECK-SAME:    %[[SRC:.*]]: memref<1xi64>) {
+func.func private @reshape_expand_scalar(%src : memref<1xi64>) {
----------------
banach-space wrote:

Mindful of https://mlir.llvm.org/docs/Dialects/MemRef/#memrefreshape-memrefreshapeop, I would avoid using `reshape` in test function names. In fact, you can just use `@expand_scalar` without loosing any info.

Similar comment for other tests.

https://github.com/llvm/llvm-project/pull/188459