[Mlir-commits] [mlir] [MLIR][AMDGPU] Added l2-prefetch op to AMDGPU (PR #188457)

[Ravil Dorozhinskii]

================
@@ -1302,5 +1302,39 @@ LogicalResult DsBarrierArriveOp::verify() {
   return verifyDsBarrierOpCommon(*this);
 }
 
+//===----------------------------------------------------------------------===//
+// GlobalPrefetchOp
+//===----------------------------------------------------------------------===//
+
+LogicalResult GlobalPrefetchOp::verify() {
+  auto src = cast<MemRefType>(getSrc().getType());
+
+  if (auto spaceAttr = dyn_cast<gpu::AddressSpaceAttr>(src.getMemorySpace())) {
----------------
ravil-mobile wrote:

Looking for that in the entire mlir sub-directory and didn't noticed that it was in the same file just a few lines above. I usually looking for such helper functions in Utils (e.g., `mlir/include/mlir/Dialect/AMDGPU/Utils/`). Yep, but probably we need `hasGlobalMemorySpace` only for verifiers; thus, makes sense.

https://github.com/llvm/llvm-project/pull/188457