[Mlir-commits] [mlir] [mlir][tosa] Harden folds/canonicalizations for unranked and dynamic shapes (PR #188188)

[Luke Hutton]

================
@@ -946,6 +955,11 @@ binaryFolder(DenseElementsAttr lhs, DenseElementsAttr rhs, ShapedType returnTy,
   if (!lhs || !rhs)
     return {};
 
+  // DenseElementsAttr::get needs a static shape. Result types may be unranked
----------------
lhutton1 wrote:

nit: this comment doesn't seem to add much value, I think we can remove it

https://github.com/llvm/llvm-project/pull/188188