[Mlir-commits] [mlir] [MLIR][SparseTensor] Add #undef FAILURE_IF_FAILED and ERROR_IF (PR #188685)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

<details>
<summary>Changes</summary>

Both DimLvlMapParser.cpp and LvlTypeParser.cpp define FAILURE_IF_FAILED and ERROR_IF macros that are never undefined, which can leak into subsequent translation units in unity builds. Add #undef at the end of each file. See https://discourse.llvm.org/t/rfc-enabling-unity-build/90306 for more info.

"clauded" not coded

---
Full diff: https://github.com/llvm/llvm-project/pull/188685.diff


2 Files Affected:

- (modified) mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp (+3) 
- (modified) mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp (+3) 


``````````diff
diff --git a/mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp b/mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp
index 2963b3463f7e0..bfb29a59255db 100644
--- a/mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp
+++ b/mlir/lib/Dialect/SparseTensor/IR/Detail/DimLvlMapParser.cpp
@@ -305,3 +305,6 @@ ParseResult DimLvlMapParser::parseLvlSpec(bool requireLvlVarBinding) {
 }
 
 //===----------------------------------------------------------------------===//
+
+#undef FAILURE_IF_FAILED
+#undef ERROR_IF
diff --git a/mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp b/mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp
index bb6c65a6f6ca0..13bf046f348d8 100644
--- a/mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp
+++ b/mlir/lib/Dialect/SparseTensor/IR/Detail/LvlTypeParser.cpp
@@ -125,3 +125,6 @@ LvlTypeParser::parseStructured(AsmParser &parser,
 }
 
 //===----------------------------------------------------------------------===//
+
+#undef FAILURE_IF_FAILED
+#undef ERROR_IF

``````````

</details>


https://github.com/llvm/llvm-project/pull/188685