[Mlir-commits] [flang] [mlir] [mlir][func] Refactor FuncToLLVM discardable attributes algorithm (PR #188232)

[llvmlistbot at llvm.org]

jeanPerier wrote:

Flang is setting more function attributes (we basically need to be able to emit most of llvm function attributes on func.func) and it is using the LLVM attribute names directly (without the llvm prefix). So your patch is now dropping some attributes that are meant to be propagated.

Many are being set [in a pass](https://github.com/llvm/llvm-project/blob/35e958d7f0b7e381d83b055607c31f3f1e3124a9/flang/lib/Optimizer/Transforms/FunctionAttr.cpp#L83) whose job is specifically to add these function attributes, some are also being set in the pass that is dealing with the passing ABI (like [here](https://github.com/llvm/llvm-project/blob/35e958d7f0b7e381d83b055607c31f3f1e3124a9/flang/lib/Optimizer/CodeGen/TargetRewrite.cpp#L783)).

https://github.com/llvm/llvm-project/pull/188232