[Mlir-commits] [mlir] [mlir][CAPI] Replace MlirIdentifier with MlirAttribute (PR #188222)

[Mehdi Amini]

joker-eph wrote:

> https://mlir.llvm.org/docs/CAPI/#type-hierarchies we do not have type hierarchies for attributes. Unless you want to open that discussion -- which this PR should not be blocked on anyway -- this PR follows the current design. And is basically a cleanup that should have been landed along [D116626](https://reviews.llvm.org/D116626).

Well, I don't agree with you analysis or conclusion: because here we're not using StringAttr as an attribute, so any discussion about attribute in general does not apply.

The C++ API unified Identifier with StringAttr for efficiency reasons (why store two string pool in the MLIRContext? The same strings would be duplicated for no reasons), but **conceptually** we're still manipulating an identifier, not an attribute like others. 
This exists in the C++ API for good reason, I don't see losing this in the C API as a "cleanup".




https://github.com/llvm/llvm-project/pull/188222