[Mlir-commits] [mlir] [mlir][func] Refactor FuncToLLVM discardable attributes algorithm (PR #188232)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Mar 24 06:06:21 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp b/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
index f0a768ee1..3a5c5c9c5 100644
--- a/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
+++ b/mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
@@ -163,7 +163,7 @@ lowerFuncAttributes(FunctionOpInterface func) {
if (odsAttrNames.contains(inherent)) {
LDBG() << "inserting to attrs: " << inherent;
lowered.attrs.emplace_back(StringAttr::get(ctx, inherent),
- attr.getValue());
+ attr.getValue());
}
} else {
lowered.attrs.push_back(attr);
``````````
</details>
https://github.com/llvm/llvm-project/pull/188232
More information about the Mlir-commits
mailing list