joker-eph wrote: The C++ is defined in terms of StringAttr, not Attribute though. So I'm not sure about the consistency argument? Is this just a naming thing? We could rename the MlirIdentifier into something referring to StringAttr. https://github.com/llvm/llvm-project/pull/188222