[Mlir-commits] [mlir] [mlir] Refactor opaque properties to make them type-safe (PR #185157)

[Krzysztof Drewniak]

krzysz00 wrote:

I actually disagree with both those removals. The nullptr conversion works by analogy with `Attribute attr = nullptr;`, which is a valid and reasonable pattern, and the `void *` constructor allows for both `PropertyRef(TypeID::get<...>(), nullptr);` and for `PropertyRef::get(TypeID::get<...>(), [result of malloc() and such]);`

And re `PropDescriptor`, I'd want to do that refactoring independent of interface support, so that we're not repeating parsing/printing code in operations all the time and so on ... and with an eye towards enabling generic parsing of properties ... which would probably involve registering instances of `PropertyDesc` with a `nullptr` in the value field into the context.

https://github.com/llvm/llvm-project/pull/185157