[Mlir-commits] [mlir] [MLIR][TableGen] Make optional enum parser not consume the token when it is not matched (PR #188008)

[Robert Konicar]

================
@@ -950,6 +950,12 @@ class AsmParser {
   parseOptionalKeyword(StringRef *keyword,
                        ArrayRef<StringRef> allowedValues) = 0;
 
+  /// Parse a string, if present, and if one of the 'allowedValues',
----------------
Jezurko wrote:

Agreed, I also like this version more. I took comments from the surrounding methods,  and just modified those...
Technically someone could make an argument to keep it like this for consistency (% adding the missing dot :)) but I don't think that's a strong argument in this case? I prefer changing it

https://github.com/llvm/llvm-project/pull/188008