[Mlir-commits] [mlir] [mlir][NFC] Add RewriterBase operand/block-arg mutation helpers (PR #187992)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/IR/PatternMatch.h mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorElimination.cpp mlir/lib/Dialect/Func/Transforms/FuncConversions.cpp mlir/lib/Dialect/GPU/IR/GPUDialect.cpp mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp mlir/lib/Dialect/Linalg/Transforms/FoldAddIntoDest.cpp mlir/lib/Dialect/Linalg/Transforms/Hoisting.cpp mlir/lib/Dialect/Linalg/Transforms/Split.cpp mlir/lib/Dialect/SCF/IR/SCF.cpp mlir/lib/Dialect/SCF/Transforms/ForToWhile.cpp mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseReinterpretMap.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp mlir/lib/Dialect/SparseTensor/Transforms/Utils/LoopEmitter.cpp mlir/lib/Dialect/Tensor/IR/TensorOps.cpp mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp mlir/lib/IR/PatternMatch.cpp mlir/lib/Interfaces/ControlFlowInterfaces.cpp mlir/lib/Transforms/Utils/CommutativityUtils.cpp mlir/test/lib/Dialect/Test/TestPatterns.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp b/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
index b5e84c378..4a3193e1c 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
@@ -310,7 +310,8 @@ LogicalResult SelectOp::canonicalize(SelectOp op, PatternRewriter &rewriter) {
   auto notOp = op.getInput1().getDefiningOp<tosa::LogicalNotOp>();
   if (!notOp)
     return failure();
-  rewriter.setOperands(op, {notOp.getInput1(), op.getOnFalse(), op.getOnTrue()});
+  rewriter.setOperands(op,
+                       {notOp.getInput1(), op.getOnFalse(), op.getOnTrue()});
   return success();
 }
 
diff --git a/mlir/lib/IR/PatternMatch.cpp b/mlir/lib/IR/PatternMatch.cpp
index de0cb5cb4..888fd011b 100644
--- a/mlir/lib/IR/PatternMatch.cpp
+++ b/mlir/lib/IR/PatternMatch.cpp
@@ -269,8 +269,7 @@ void RewriterBase::eraseBlockArguments(Block *block,
 void RewriterBase::eraseBlockArguments(
     Block *block, function_ref<bool(BlockArgument)> shouldEraseFn) {
   if (Operation *parentOp = block->getParentOp()) {
-    modifyOpInPlace(parentOp,
-                    [&]() { block->eraseArguments(shouldEraseFn); });
+    modifyOpInPlace(parentOp, [&]() { block->eraseArguments(shouldEraseFn); });
     return;
   }
   block->eraseArguments(shouldEraseFn);
@@ -318,8 +317,7 @@ void RewriterBase::setOperands(Operation *op, ValueRange operands) {
 
 void RewriterBase::setOperands(Operation *op, unsigned start, unsigned length,
                                ValueRange operands) {
-  modifyOpInPlace(
-      op, [&]() { op->setOperands(start, length, operands); });
+  modifyOpInPlace(op, [&]() { op->setOperands(start, length, operands); });
 }
 
 void RewriterBase::setOperand(Operation *op, unsigned index, Value value) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/187992