[Mlir-commits] [mlir] [MLIR][TableGen] Make optional enum parser not consume the token when it is not matched (PR #188008)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- mlir/include/mlir/IR/OpImplementation.h mlir/lib/AsmParser/AsmParserImpl.h mlir/tools/mlir-tblgen/EnumsGen.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/include/mlir/IR/OpImplementation.h b/mlir/include/mlir/IR/OpImplementation.h
index 43e650db0..66c08e5e8 100644
--- a/mlir/include/mlir/IR/OpImplementation.h
+++ b/mlir/include/mlir/IR/OpImplementation.h
@@ -967,8 +967,8 @@ public:
   /// Parse an optional keyword or string.
   virtual ParseResult parseOptionalKeywordOrString(std::string *result) = 0;
 
-  /// Parse an optional keyword or string, if present, and if one of the 'allowedValues',
-  /// into 'result'
+  /// Parse an optional keyword or string, if present, and if one of the
+  /// 'allowedValues', into 'result'
   virtual ParseResult
   parseOptionalKeywordOrString(std::string *result,
                                ArrayRef<StringRef> allowedValues) = 0;

``````````

</details>


https://github.com/llvm/llvm-project/pull/188008