[Mlir-commits] [mlir] [mlir][vector] Drop trailing 1-dims from constant_mask (PR #187383)

[Andrzej Warzyński]

================
@@ -522,21 +532,23 @@ class TransferReadDropUnitDimsPattern
     Value maskOp = transferReadOp.getMask();
     if (maskOp) {
       LDBG() << "  -> Processing mask operation";
-      auto createMaskOp = maskOp.getDefiningOp<vector::CreateMaskOp>();
-      if (!createMaskOp) {
-        LDBG()
-            << "  -> Unsupported mask op, only 'vector.create_mask' supported";
-        return rewriter.notifyMatchFailure(
-            transferReadOp, "unsupported mask op, only 'vector.create_mask' is "
-                            "currently supported");
-      }
-      FailureOr<Value> rankReducedCreateMask =
-          createMaskDropNonScalableUnitDims(rewriter, loc, createMaskOp);
-      if (failed(rankReducedCreateMask)) {
+      FailureOr<Value> rankReducedMask = failure();
----------------
banach-space wrote:

[nit] For consistency with e.g. `maskOp`:
```suggestion
      FailureOr<Value> rankReducedMaskOp = failure();
```

https://github.com/llvm/llvm-project/pull/187383