[Mlir-commits] [mlir] [mlir][vector] Drop trailing 1-dims from constant_mask (PR #187383)

[Andrzej Warzyński]

================
@@ -429,30 +429,40 @@ static VectorType trimNonScalableUnitDims(VectorType oldType) {
   return VectorType::get(newShape, oldType.getElementType(), newScalableDims);
 }
 
-// Rewrites vector.create_mask 'op' to drop non-scalable one dimensions.
-static FailureOr<Value>
-createMaskDropNonScalableUnitDims(PatternRewriter &rewriter, Location loc,
-                                  vector::CreateMaskOp op) {
+static auto getMaskDimData(vector::CreateMaskOp op) { return op.getOperands(); }
+static auto getMaskDimData(vector::ConstantMaskOp op) {
+  return op.getMaskDimSizes();
+}
----------------
banach-space wrote:

We should unify the naming - could you leave a TODO to update `CreaterMaskOp` argument names so that this is not required? Better till, would you be happy to refactor `Vector` accordingly?

https://github.com/llvm/llvm-project/pull/187383