[Mlir-commits] [flang] [llvm] [mlir] [Flang][OpenMP] Remove dead restoreIP in OpenMP taskloop lowering (PR #187222)

[Tom Eccles]

================

----------------
tblah wrote:

Thanks for the update. The new mlir test looks good.

We are usually quite strict on the addition of Fortran -> LLVM style tests (such as this one) because they can be burdensome to maintain (a change anywhere in flang's pipeline could require the test to be updated). They go in `flang/test/Integration/OpenMP/`.

In this case I think the risk of your test becoming a maintenance burden is quite low because your CHECK lines are so well targeted. Keep the test if you want, but please move it into the right directory (flang/test/Lower is for Fortran -> HLFIR tests), and add the comment used in (most of) the other integration tests to discourage people from adding new ones unless necessary. 

https://github.com/llvm/llvm-project/pull/187222