[Mlir-commits] [mlir] [OpenACC][NFC] Generalize wrapMultiBlockRegionWithSCFExecuteRegion (PR #187359)

[Razvan Lupusoru]

================
@@ -149,15 +148,13 @@ cloneACCRegionInto(Region *src, Block *dest, Block::iterator inlinePoint,
 /// Wrap a multi-block region with scf.execute_region.
 scf::ExecuteRegionOp
 wrapMultiBlockRegionWithSCFExecuteRegion(Region &region, IRMapping &mapping,
-                                         Location loc, RewriterBase &rewriter,
-                                         bool convertFuncReturn) {
+                                         Location loc, RewriterBase &rewriter) {
   SmallVector<Operation *> terminators;
   for (Block &block : region.getBlocks()) {
     if (block.empty())
       continue;
     Operation *term = block.getTerminator();
-    if ((convertFuncReturn && isa<func::ReturnOp>(*term)) ||
-        isa<acc::YieldOp>(*term))
+    if (term->getNumSuccessors() == 0)
----------------
razvanlupusoru wrote:

Sounds good. Thank you for your explanations.

https://github.com/llvm/llvm-project/pull/187359