[Mlir-commits] [mlir] [mlir] Enhance dimOp fold (PR #187286)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

The dim resolution is handled in a generic way using https://github.com/llvm/llvm-project/blob/b11a603a45e11cad6b22840c2f780c66b5635f58/mlir/include/mlir/Interfaces/InferTypeOpInterface.td#L352 (the existing "dim op canonicalizations" probably need to be removed to be consistent with rest of the world).

You can just run [`--resolve-ranked-shaped-type-result-dims`](https://github.com/llvm/llvm-project/blob/b11a603a45e11cad6b22840c2f780c66b5635f58/mlir/include/mlir/Dialect/MemRef/Transforms/Passes.td#L159) to handle this through the interface. This change is unnecessary

https://github.com/llvm/llvm-project/pull/187286