[Mlir-commits] [mlir] [mlir][python] Correctly handle python passes that emit errors without signalling failure. (PR #96996)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/python/CMakeFiles/MLIRPythonModules.extension._mlir.dso.dir/C_/_work/llvm-project/llvm-project/mlir/lib/Bindings/Python/Pass.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/python/CMakeFiles/MLIRPythonModules.extension._mlir.dso.dir/C_/_work/llvm-project/llvm-project/mlir/lib/Bindings/Python/Pass.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DMLIRPythonModules_extension__mlir_dso_EXPORTS -DMLIR_BINDINGS_PYTHON_DOMAIN=mlir -DMLIR_INCLUDE_TESTS -DMLIR_PYTHON_PACKAGE_PREFIX=mlir. -DNB_DOMAIN=mlir -DNB_SHARED -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\python -IC:\_work\llvm-project\llvm-project\mlir\python -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvcC:\Python312\include -imsvcC:\Python312\Lib\site-packages\nanobind\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags /O2 /Ob2  -std:c++17 -MD -UNDEBUG /bigobj /MP /Os -Wno-c++98-compat-extra-semi -Wno-cast-qual -Wno-covered-switch-default -Wno-deprecated-literal-operator -Wno-nested-anon-types -Wno-unused-parameter -Wno-zero-length-array -Wno-missing-field-initializers /EHsc /GR /showIncludes /Fotools\mlir\python\CMakeFiles\MLIRPythonModules.extension._mlir.dso.dir\C_\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp.obj /Fdtools\mlir\python\CMakeFiles\MLIRPythonModules.extension._mlir.dso.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp(273,23): error: use of undeclared identifier 'py'
273 |                 throw py::error_already_set();
|                       ^
1 error generated.
```
</details>
<details>
<summary>[code=1] tools/mlir/python/CMakeFiles/MLIRPythonModules.extension._mlirDialectsTransform.dso.dir/C_/_work/llvm-project/llvm-project/mlir/lib/Bindings/Python/Pass.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/python/CMakeFiles/MLIRPythonModules.extension._mlirDialectsTransform.dso.dir/C_/_work/llvm-project/llvm-project/mlir/lib/Bindings/Python/Pass.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DMLIRPythonModules_extension__mlirDialectsTransform_dso_EXPORTS -DMLIR_BINDINGS_PYTHON_DOMAIN=mlir -DMLIR_INCLUDE_TESTS -DMLIR_PYTHON_PACKAGE_PREFIX=mlir. -DNB_DOMAIN=mlir -DNB_SHARED -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\python -IC:\_work\llvm-project\llvm-project\mlir\python -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvcC:\Python312\include -imsvcC:\Python312\Lib\site-packages\nanobind\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags /O2 /Ob2  -std:c++17 -MD -UNDEBUG /bigobj /MP /Os -Wno-c++98-compat-extra-semi -Wno-cast-qual -Wno-covered-switch-default -Wno-deprecated-literal-operator -Wno-nested-anon-types -Wno-unused-parameter -Wno-zero-length-array -Wno-missing-field-initializers /EHsc /GR /showIncludes /Fotools\mlir\python\CMakeFiles\MLIRPythonModules.extension._mlirDialectsTransform.dso.dir\C_\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp.obj /Fdtools\mlir\python\CMakeFiles\MLIRPythonModules.extension._mlirDialectsTransform.dso.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Bindings\Python\Pass.cpp(273,23): error: use of undeclared identifier 'py'
273 |                 throw py::error_already_set();
|                       ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/96996