[Mlir-commits] [mlir] [mlir][tosa][tosa-to-linalg] Fix rescale with double rounding failing validation (PR #184787)

[Thomas Preud'homme]

RoboTux wrote:

> > If the goal is to describe what the TosaToLinalg pipeline supports, why is it a parameter of addTosaToLinalgPasses? Can't you just set the target options like what is done when the argument is nullopt?
> 
> My thinking was that customization of target options are important for a user of `addTosaToLinalgPasses` that enabled the "strict-op-spec-alignment" validation option. If the ability to customize target options wasn't available the pipeline could complain about missing extensions. Once this pipeline declares all the extensions it supports, I think we could remove this option.

Ok, so user might know the target and hope the pipeline supports all the extension needed for that target. Ok.

https://github.com/llvm/llvm-project/pull/184787