[Mlir-commits] [mlir] [mlir][arith] Use type parser instead of hard-coding type keywords (PR #186753)

[Mehdi Amini]

================
@@ -1,4 +1,9 @@
-// RUN: mlir-opt --split-input-file --arith-emulate-unsupported-floats="source-types=bf16,f8E4M3FNUZ target-type=f32" %s | FileCheck %s
+// RUN: mlir-opt --arith-emulate-unsupported-floats="source-types=bf16,f8E4M3FNUZ target-type=f32" %s | FileCheck %s
+// RUN: mlir-opt --arith-emulate-unsupported-floats="source-types=bf16,f8E4M3FNUZ target-type=!llvm.ppc_fp128" %s | FileCheck %s --check-prefix=CHECK-PPC
+
+// Arbitrary op from the LLVM dialect to ensure that the LLVM dialect is loaded.
+// The LLVM dialect is needed for the !llvm.ppc_fp128 test run.
----------------
joker-eph wrote:

> Is there an API for that? I was trying to call this function in getDependentDialects, but I don't know the type ID:

Right, that wouldn't work. I think that means that `arith-emulate-unsupported-floats` needs to be locked down to a specific list of possible dialect it accepts in the `target-type`

https://github.com/llvm/llvm-project/pull/186753