[Mlir-commits] [mlir] [MLIR][Presburger] Add support for Smith normal form (PR #185328)

[Arjun Pitchanathan]

================
@@ -628,9 +628,9 @@ IntMatrix::computeSmithNormalForm() const {
       // Find the entry in the submatrix d(i:, i:) with the smallest non-zero
       // absolute value.
       // The element is the pivot, and we record its current row and column.
-      auto pivotPos = nonZeroMinInSubmatrix(d, i);
+      auto pivotPos = findNonZeroMinInSubmatrix(d, i);
       if (!pivotPos)
-        continue;
+        break;
----------------
superty wrote:

can you add a regression test for this if it doesn't fail any of the current tests

https://github.com/llvm/llvm-project/pull/185328