[Mlir-commits] [mlir] [mlir][bytecode] Fix crashes when reading bytecode with unsupported types (PR #186354)
Akimasa Watanuki
llvmlistbot at llvm.org
Mon Mar 16 05:14:29 PDT 2026
Men-cotton wrote:
> > Since these use the same test setup and cover closely related invalid type-remapping failures, could we merge them into a single `-split-input-file` test instead of adding two new files? If we do that, I think a broader name like `mlir/test/Bytecode/invalid/invalid-type-remapping.mlir` would fit the merged coverage.
>
> Sure, done.
I just realized we already have an existing test covering the same setup here: `mlir/test/Bytecode/invalid/invalid-dense-elem-type-interface.mlir`.
Since that one also exercises the same `--test-bytecode-roundtrip="test-kind=2"` type-remapping path, I think it would be better to fold it into `mlir/test/Bytecode/invalid/invalid-type-remapping.mlir` as well.
https://github.com/llvm/llvm-project/pull/186354
More information about the Mlir-commits
mailing list