[Mlir-commits] [mlir] [mlir] Add normalize pass to MLIR (PR #186647)

[lonely eagle]

linuxlonelyeagle wrote:

> I think this PR and the pass description would likely benefit from describing the goals and intend of this pass. It's not trying to be an optimization pass (so things like undoing LICM seem fine to me) IIRC. Rather it is trying to increase syntactic equivalence of code to reduce diff size while retaining semantic equivalence right?
> 

> I think this is important to note such that no one accidentally uses it instead of the canonicalization pass (a pass that aims for increasing semantic equivalence instead).

Yes.


https://github.com/llvm/llvm-project/pull/186647