[Mlir-commits] [mlir] [mlir] Fix UB in comparator lambdas in getRegisteredOperationsByDialect (PR #186428)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/IR/CMakeFiles/obj.MLIRIR.dir/MLIRContext.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/IR/CMakeFiles/obj.MLIRIR.dir/MLIRContext.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\IR -IC:\_work\llvm-project\llvm-project\mlir\lib\IR -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\IR\CMakeFiles\obj.MLIRIR.dir\MLIRContext.cpp.obj /Fdtools\mlir\lib\IR\CMakeFiles\obj.MLIRIR.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\IR\MLIRContext.cpp
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\IR\MLIRContext.cpp:12:
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\IR\AttributeDetail.h:18:
C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/BuiltinAttributes.h(346,14): warning: 'complex' is deprecated: warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. [-Wdeprecated-declarations]
346 |       return {APFloat(*smt, value.real()), APFloat(*smt, value.imag())};
|              ^
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\complex(1333,5): note: 'complex' has been explicitly marked deprecated here
1333 |     _DEPRECATE_NONFLOATING_COMPLEX
|     ^
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\yvals_core.h(1413,7): note: expanded from macro '_DEPRECATE_NONFLOATING_COMPLEX'
1413 |     [[deprecated("warning STL4037: "                                                   \
|       ^
C:\_work\llvm-project\llvm-project\mlir\lib\IR\MLIRContext.cpp(1002,54): error: invalid operands to binary expression ('StringAttr' and 'StringAttr')
1002 |                           return lhs.getIdentifier() < rhs.getIdentifier();
|                                  ~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
C:\BuildTools\VC\Tools\MSVC\14.44.35207\include\xutility(7471,13): note: in instantiation of function template specialization 'mlir::RegisteredOperationName::insert(std::unique_ptr<RegisteredOperationName::Impl>, ArrayRef<StringRef>)::(lambda)::operator()<const mlir::RegisteredOperationName, mlir::RegisteredOperationName>' requested here
7471 |         if (_Pred(_Val, *_UMid)) {
|             ^
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/STLExtras.h(2072,15): note: in instantiation of function template specialization 'std::upper_bound<mlir::RegisteredOperationName *, mlir::RegisteredOperationName, (lambda at C:\_work\llvm-project\llvm-project\mlir\lib\IR\MLIRContext.cpp:1001:25)>' requested here
2072 |   return std::upper_bound(adl_begin(Range), adl_end(Range),
|               ^
1 warning and 1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/186428