[Mlir-commits] [mlir] [MLIR][Vector] Remove implicit bitcast behavior from vector.extract (PR #186383)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

Thank you for proposing this @joker-eph ! This removes ambiguity and aligns the implementation with `vector.extract`  [docs](https://mlir.llvm.org/docs/Dialects/Vector/#vectorextract-vectorextractop):

> Extracts an (n − k)-D result **sub-vector** from an n-D source vector at a specified k-D position. When n = k, the result degenerates to a scalar element.

Btw, aren't we missing some new tests in invalid.mlir?

Approving as is, but mindful of https://discourse.llvm.org/t/rfc-remove-implicit-bitcast-behavior-of-vector-extract/ (and previous discussions in this area), please wait for at least one more +1 before landing (*).

LGTM!

(*) Though lets not wait more than a week, that should be plenty of time for folks to raise potential objections.

https://github.com/llvm/llvm-project/pull/186383