[Mlir-commits] [mlir] [mlir][vector] Fix vector.gather lowering for strided memrefs. (PR #184706)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

Thanks for the ping, @hanhanW , and sorry for missing this!

LGTM % comments. 

Basically, I have two asks:
* Align variable names with what we use in the docs (and op definitions): https://mlir.llvm.org/docs/Dialects/Vector/#vectorgather-vectorgatherop (e.g. `offsets` + `indices` for `vector.gather`) and use that consistently. I know that we didn't use to be strict about this, but it is just too easy to confuse e.g. `offsets` and `indices` 😅 .
* Edit the test to make it clear what differentiates it from other tests that are similar (e.g. ` @gather_memref_non_unit_stride_read_more_than_1_element` + ` @strided_gather`).

I've left some specific comments inline - hopefully that will be helpful. 

https://github.com/llvm/llvm-project/pull/184706