[Mlir-commits] [mlir] [mlir][memref] Rewrite scalar `memref.copy` through reinterpret_cast into load/store (PR #186118)

[Andrzej Warzyński]

================
@@ -11,6 +11,11 @@
 
 include "mlir/Pass/PassBase.td"
 
+def BypassReinterpretCastPass : Pass<"memref-bypass-reinterpret-cast"> {
+  let summary = "Replace ops depending on redundant reinterpret casts to be "
+                "convertible to EmitC.";
----------------
banach-space wrote:

I would make this (and similar comments) more explicit. IIUC, this will also apply to the future patterns that you will add?
```suggestion
  let summary = "Replace ops that move data and depend on redundant memref.reinterpret_cast(s) to provide compatible shapes with other ops that achieve similar data movement without requiring memref.reinterpret_cast(s). This helps simplify the conversion to EmitC.";
```

https://github.com/llvm/llvm-project/pull/186118