[Mlir-commits] [mlir] [mlir][spirv] Introduce base classes for Integer and Bool elementwise binary ops (PR #185904)

[Igor Wodiany]

https://github.com/IgWod approved this pull request.

> If you are thinking of using that pattern for all elementwise binary ops that does not generalize well

Yes, I was thinking that. In this case I think we can keep it as it is and we can always refactor it further later. We want to minimise duplication, but also I'd be concerned we end up with too many different cases in this file, making things just difficult to follow.

https://github.com/llvm/llvm-project/pull/185904