[Mlir-commits] [mlir] [mlir][spirv][gpu] Add lowering for `gpu.subgroup_broadcast` (PR #185818)

[Igor Wodiany]

https://github.com/IgWod requested changes to this pull request.

Thank you for your contribution! In addition to the specific feedback I have few more high-level comments:

1) We also need tests for the new op in: https://github.com/llvm/llvm-project/blob/main/mlir/test/Target/SPIRV/non-uniform-ops.mlir.
2) We also need a lit test for the conversion.
3) My preference would be to land the new op and the conversion as two separate PRs.

https://github.com/llvm/llvm-project/pull/185818