[Mlir-commits] [clang] [mlir] [CIR] Set `builtin` attribute for new and delete calls (PR #184920)

[Erich Keane]

erichkeane wrote:

> > There are 2 more tests for MLIR that need to happen, see Dialect/LLVMIR/func.mlir and target/LLVMIR/Import/function-attributes.ll I think (that will fill out the list of ones that ended up getting full coverage for me!).
> > I THINK that becasue of this you're missing some of the changes to ModuleTranslation.cpp/h.
> > See: [8cf99c2](https://github.com/llvm/llvm-project/commit/8cf99c263ef9099e58c7143de3c611190cb556ed)
> 
> The "builtin" attribute is only valid on call sites, not functions. So that means I don't need those tests, right?

Ah, yep, you're correct!  Sorry for the delay, your message got lost in the above discussion.


https://github.com/llvm/llvm-project/pull/184920