[Mlir-commits] [mlir] [MLIR][Mem2Reg] Add support for region control flow and SCF (PR #185036)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/lib/Dialect/SCF/IR/MemorySlot.cpp mlir/include/mlir/Dialect/SCF/IR/SCF.h mlir/lib/Transforms/Mem2Reg.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Transforms/Mem2Reg.cpp b/mlir/lib/Transforms/Mem2Reg.cpp
index 8e2f31f85..29c5662c5 100644
--- a/mlir/lib/Transforms/Mem2Reg.cpp
+++ b/mlir/lib/Transforms/Mem2Reg.cpp
@@ -603,9 +603,9 @@ Value MemorySlotPromoter::promoteInBlock(Block *block, Value reachingDef) {
             slot, reachingDef, hasValueStores, reachingAtBlockEnd, builder);
 
         // Blocking uses can then be removed for the regions that were promoted.
-        // Even though `finalizePromotion` may have moved regions to a new operation,
-        // `removeBlockingUses` handles this case and will redirect processing to
-        // the correct region.
+        // Even though `finalizePromotion` may have moved regions to a new
+        // operation, `removeBlockingUses` handles this case and will redirect
+        // processing to the correct region.
         for (auto &[region, reachingDef] : regionsToProcess)
           removeBlockingUses(region);
       }

``````````

</details>


https://github.com/llvm/llvm-project/pull/185036