[Mlir-commits] [mlir] [MLIR][Linalg] Prevent PackOp canonicalization crash on zero tile factor (PR #185624)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3537 tests passed
* 415 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Dialect/Linalg/pack-zero-tile-after-sccp-invalid.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Linalg\pack-zero-tile-after-sccp-invalid.mlir -split-input-file -verify-diagnostics
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Linalg\pack-zero-tile-after-sccp-invalid.mlir' -split-input-file -verify-diagnostics
# .---command stdout------------
# | module {
# |   func.func @get_tile_size() -> index {
# |     %c0 = arith.constant 0 : index
# |     return %c0 : index
# |   }
# |   func.func private @use(tensor<?x16x?x1xi32>)
# |   func.func @pack(%arg0: tensor<7x16xi32>) {
# |     %c1 = arith.constant 1 : index
# |     %c123_i32 = arith.constant 123 : i32
# |     %0 = call @get_tile_size() : () -> index
# |     %1 = tensor.empty(%c1, %0) : tensor<?x16x?x1xi32>
# |     %pack = linalg.pack %arg0 padding_value(%c123_i32 : i32) inner_dims_pos = [0, 1] inner_tiles = [%0, 1] into %1 : tensor<7x16xi32> -> tensor<?x16x?x1xi32>
# |     call @use(%pack) : (tensor<?x16x?x1xi32>) -> ()
# |     return
# |   }
# | }
# | 
# `-----------------------------
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Dialect\Linalg\pack-zero-tile-after-sccp-invalid.mlir:15:6: error: expected error "invalid zero tile factor" was not produced
# |   // expected-error @below {{invalid zero tile factor}}
# |      ^~~~~~~~~~~~~~~~~~~~~~~~
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/185624