[Mlir-commits] [mlir] [MLIR][Mem2Reg] Add support for region control flow and SCF (PR #185036)

[Tobias Gysi]

https://github.com/gysit commented:

Very nice work!

I think the interface strikes a good balance between functionality and implementation complexity. Downstream we have a similar interface with some extra features - such as adding multiple values at the same time - which results quite a bit of extra complexity. I think it is good to avoid it here - especially since the use case anyways promotes just one value at the time. 


https://github.com/llvm/llvm-project/pull/185036