[Mlir-commits] [mlir] [mlir][LLVM] Add support for `ptrtoaddr` (PR #185104)

[Tobias Gysi]

Markus =?utf-8?q?Böck?= <markus.boeck02 at gmail.com>,
Markus =?utf-8?q?Böck?= <markus.boeck02 at gmail.com>,
Markus =?utf-8?q?Böck?= <markus.boeck02 at gmail.com>,
Markus =?utf-8?q?Böck?= <markus.boeck02 at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/185104 at github.com>


================
@@ -629,6 +629,48 @@ def LLVM_IntToPtrOp : LLVM_DereferenceableCastOp<"inttoptr", "IntToPtr",
 def LLVM_PtrToIntOp : LLVM_CastOp<"ptrtoint", "PtrToInt",
                                   LLVM_ScalarOrVectorOf<LLVM_AnyPointer>,
                                   LLVM_ScalarOrVectorOf<AnySignlessInteger>>;
+
+def LLVM_PtrToAddrOp : LLVM_CastOp<"ptrtoaddr", "PtrToAddr",
+                                  LLVM_ScalarOrVectorOf<LLVM_AnyPointer>,
+                                  LLVM_ScalarOrVectorOf<AnySignlessInteger>> {
+  let llvmBuilder = "$res = builder.CreatePtrToAddr($arg);";
----------------
gysit wrote:

```suggestion
  // Overwrite the base class llvmBuilder since the instruction doesn't take a destination type argument.
  let llvmBuilder = "$res = builder.CreatePtrToAddr($arg);";
```
ultra nit: I would add a small comment here since the base class already defines an LLVM builder.

https://github.com/llvm/llvm-project/pull/185104