https://github.com/banach-space approved this pull request. Nice crafted, thanks! LGTM in principle, but I left a few minor comments that I'd like addressed. Feel free to ignore nits. https://github.com/llvm/llvm-project/pull/184624